Skip to content

Add dpnp.ndarray.__format__ method #2662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 13, 2025
Merged

Add dpnp.ndarray.__format__ method #2662

merged 7 commits into from
Nov 13, 2025

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 10, 2025 •
edited
Loading

The PR implements a special python method __format__ for dpnp.ndarray.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Nov 10, 2025
@antonwolfy antonwolfy self-assigned this Nov 10, 2025
@antonwolfy antonwolfy changed the title Add special python method __format__ to dpnp,ndarray Add dpnp.ndarray.__format__ method Nov 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Nov 10, 2025 •
edited
Loading

Coverage Status

coverage: 81.458% (+0.001%) from 81.457%
when pulling b736ad8 on add-format-method-impl
into f0eb0a8 on master.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_51 ran successfully.
Passed: 1229
Failed: 0
Skipped: 7

@antonwolfy antonwolfy marked this pull request as ready for review November 11, 2025 13:56
vlad-perevezentsev
vlad-perevezentsev approved these changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 789d3eb into master Nov 13, 2025
120 of 123 checks passed
@antonwolfy antonwolfy deleted the add-format-method-impl branch November 13, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

0.20.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @vlad-perevezentsev